brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Check benchmarks on CI #96

Closed sfmig closed 5 months ago

sfmig commented 5 months ago

This PR follows from #94


Description

What is this PR

Why is this PR needed? To test the benchmarks.

What does this PR do? We test the benchmarks on CI rather than with tests.

References from other Python packages using asv to benchmark:

Currently we are running a very basic check. We can look into further extending this with maybe something closer to the napari or numpy approaches (see below).

References

This PR follows from #94 and relates to issue #9. It should be rebased to main after #94 is squash-and-merged.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.69%. Comparing base (34b07ec) to head (e097500).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ========================================== + Coverage 84.45% 85.69% +1.24% ========================================== Files 17 16 -1 Lines 862 839 -23 ========================================== - Hits 728 719 -9 + Misses 134 120 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.