search

brainglobe / brainglobe-workflows

Workflows that utilise BrainGlobe tools to perform data analysis and visualisation.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Cache cellfinder model in CI #97

Closed sfmig closed 2 months ago

sfmig commented 2 months ago

Description

What is this PR

Why is this PR needed? We are inspecting why CI is slow (work in progress) and this seemed a low hanging fruit which may improve a bit our timings.

What does this PR do? It adds a step in the CI workflow for tests, for caching the cellfinder model. This is implemented in cellfinder CI but not here.

References

Related to #65.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.38%. Comparing base (0fd2e4f) to head (e8a3d08).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ======================================= Coverage 79.38% 79.38% ======================================= Files 18 18 Lines 917 917 ======================================= Hits 728 728 Misses 189 189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.