search

brainglobe / brainglobe.github.io

brainglobe.info website
https://brainglobe.info/
Creative Commons Attribution 4.0 International
10 stars 8 forks source link

Update dependency tree in light of widget refactoring. #163

Closed willGraham01 closed 4 months ago

willGraham01 commented 6 months ago

Since brainrender-napari now fetches it's widgets from brainglobe-utils, we need to update the dependency tree to reflect this.

Staging this PR until a new version of the metapackage with all necessary new versions released and updated is ready. @K-Meech

adamltyson commented 5 months ago

A new version of the metapackage has now been released. There's been some movement of code (e.g. from cellfinder -> brainglobe-utils), but I think the new dependency tree is still valid.

alessandrofelder commented 5 months ago

I think it's missing the dependency of brainrender-napari on brainglobe-utils, introduced here.

alessandrofelder commented 5 months ago

...in other words, I think this could/should be merged... but looks like we're replacing a light-mode image with a dark-mode image?

adamltyson commented 5 months ago

Oh yeah it should probably be in light mode

alessandrofelder commented 4 months ago

@willGraham01 could you have another look at this and ask for my review?

willGraham01 commented 4 months ago

Should be in light mode now - I think this was opened with the changes in https://github.com/brainglobe/brainglobe-meta/pull/49/ in mind, so if no other package dependencies have been moved around, things should be OK.