brainglobe / brainreg

Automated 3D brain registration with support for multiple species and atlases.
https://brainglobe.info/documentation/brainreg/index.html
BSD 3-Clause "New" or "Revised" License
116 stars 26 forks source link

Seperate preprocessing from registration #157

Closed adamltyson closed 7 months ago

adamltyson commented 2 years ago

Currently the preprocessing is fixed, and based upon serial2p datasets. The preprocessing should be a seperate step, potentially leveraging existing napari plugins.

Options could include:

noisysky commented 2 years ago

@adamltyson Sure, I'll try to make it a bit more general (get rid of hardcoded values). Any guidance on how to incorporate it to brainreg-napari will be greatly appreciated. Should it be a command-line argument like --preprocessing fmost?

horsto commented 2 years ago

@adamltyson - indeed I got it working with our LSFM data, quite well actually. I did not add any preprocessing but rather fixed some of the imaging parameters which helped to clean up our data and make the alignment process smooth.

adamltyson commented 2 years ago

@noisysky - I think that's probably a good place to start, if we have the different preprocessing modules within brainreg, we can add the plugin functionality later. Perhaps this file could be refactored so that we have a collection of standalone functions, and then wrapper functions like preprocess_stpt, preprocess_fmost etc.

adamltyson commented 2 years ago

@horsto great to hear. I'd love to see the results sometime!

adamltyson commented 7 months ago

Closing in favour of https://github.com/brainglobe/brainglobe-registration