brainglobe / brainreg

Automated 3D brain registration with support for multiple species and atlases.
https://brainglobe.info/documentation/brainreg/index.html
BSD 3-Clause "New" or "Revised" License
121 stars 27 forks source link

CI on both types of Macs #191

Closed alessandrofelder closed 5 months ago

alessandrofelder commented 5 months ago

Description

What is this PR

Why is this PR needed?

We'd like to run CI on both Intel and Silicon Macs.

What does this PR do?

This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.

References

Partial solution to https://github.com/brainglobe/BrainGlobe/issues/63

How has this PR been tested?

CI runs observed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

adamltyson commented 5 months ago

@alessandrofelder FYI I think for macos-latest to work, it will need niftyreg installed via conda. This package only ships with binaries built for intel macs.

alessandrofelder commented 5 months ago

superceded by #196