Manage atlas versions in a separate widget

alessandrofelder commented 9 months ago

Description

What is this PR

[ ] Bug fix
[x] Addition of a new feature
[ ] Other

Why is this PR needed? We'd like to separate atlas version management from atlas visualisation in the GUI.

What does this PR do?

creates a new widget for atlas version management
in the background, separates models/views into their own files (as we now have more than one view for the same model)

References

Closes #21

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

[x] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[x] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

codecov[bot] commented 9 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (94aff08) 97.44% compared to head (b0609a0) 96.78%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== - Coverage 97.44% 96.78% -0.66% ========================================== Files 8 12 +4 Lines 391 467 +76 ========================================== + Hits 381 452 +71 - Misses 10 15 +5 ``` | [Files](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [brainrender\_napari/\_\_init\_\_.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [brainrender\_napari/atlas\_version\_manager\_widget.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL2F0bGFzX3ZlcnNpb25fbWFuYWdlcl93aWRnZXQucHk=) | `100.00% <100.00%> (ø)` | | | [brainrender\_napari/brainrender\_widget.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL2JyYWlucmVuZGVyX3dpZGdldC5weQ==) | `100.00% <100.00%> (ø)` | | | [...rainrender\_napari/data\_models/atlas\_table\_model.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL2RhdGFfbW9kZWxzL2F0bGFzX3RhYmxlX21vZGVsLnB5) | `100.00% <100.00%> (ø)` | | | [brainrender\_napari/utils/brainglobe\_logo.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL3V0aWxzL2JyYWluZ2xvYmVfbG9nby5weQ==) | `100.00% <100.00%> (ø)` | | | [brainrender\_napari/widgets/atlas\_manager\_dialog.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL3dpZGdldHMvYXRsYXNfbWFuYWdlcl9kaWFsb2cucHk=) | `100.00% <100.00%> (ø)` | | | [brainrender\_napari/widgets/structure\_view.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL3dpZGdldHMvc3RydWN0dXJlX3ZpZXcucHk=) | `100.00% <100.00%> (+6.61%)` | :arrow_up: | | [brainrender\_napari/widgets/atlas\_viewer\_view.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL3dpZGdldHMvYXRsYXNfdmlld2VyX3ZpZXcucHk=) | `98.14% <98.14%> (ø)` | | | [brainrender\_napari/widgets/atlas\_manager\_view.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL3dpZGdldHMvYXRsYXNfbWFuYWdlcl92aWV3LnB5) | `88.23% <88.23%> (ø)` | | | [...nrender\_napari/data\_models/structure\_tree\_model.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL2RhdGFfbW9kZWxzL3N0cnVjdHVyZV90cmVlX21vZGVsLnB5) | `90.69% <90.69%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alessandrofelder commented 6 months ago

Closing in favour of a few smaller PRs.

brainglobe / brainrender-napari