brainglobe / brainrender-napari

A napari plugin to render BrainGlobe atlases and associated data as layers.
BSD 3-Clause "New" or "Revised" License
19 stars 1 forks source link

drop py3.8, support 3.11 #101

Closed alessandrofelder closed 1 year ago

alessandrofelder commented 1 year ago

Description

What is this PR

Why is this PR needed? We adhere to NEP 29 (and support for 3.8 was causing me problems cross-Python-version compatibility with importlib.resources in #91 )

What does this PR do? Drop Python 3.8 support and optimistically support 3.11 (napari supports 3.11 for a few months now, I think).

References

Closes #102

How has this PR been tested?

Is this a breaking change?

Yes, for Python 3.8 users.

Does this PR require an update to the documentation?

Adherence to NEP 29 already official in our developer conventions, so no.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (d353a1e) 97.30% compared to head (a204460) 97.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #101 +/- ## ======================================= Coverage 97.30% 97.30% ======================================= Files 7 7 Lines 371 371 ======================================= Hits 361 361 Misses 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.