search

brainglobe / brainrender-napari

A napari plugin to render BrainGlobe atlases and associated data as layers.
BSD 3-Clause "New" or "Revised" License
19 stars 1 forks source link

[Feature] Use colours provided by `bg-atlasapi` to render annotation labels #114

Open alessandrofelder opened 10 months ago

alessandrofelder commented 10 months ago

Is your feature request related to a problem? Please describe. Some atlases, such as the Allen Mouse, provide colours for each of the regions of the annotations. We currently use these to colour the meshes, but not the annotation.

Describe the solution you'd like We could use DIRECT colour mode for the napari labels layer to map the atlas colours to the annotation.

Describe alternatives you've considered n/a

Additional context Might be good to double-check rendering performance in napari if/when we implement this. See https://github.com/napari/napari/issues/6397 - @Czaki kindly warned us that the fix for this may not help with DIRECT color mode.

Czaki commented 10 months ago

the https://github.com/napari/napari/pull/6439 is fix for direct color mode

alessandrofelder commented 10 months ago

Ah, even better, then :) thank you @Czaki !