brainglobe / brainrender-napari

A napari plugin to render BrainGlobe atlases and associated data as layers.
BSD 3-Clause "New" or "Revised" License
19 stars 1 forks source link

[Feature] Investigate leveraging `napari-vedo-bridge` #151

Open adamltyson opened 1 month ago

adamltyson commented 1 month ago

This issue is to track how we could make use of napari-vedo-bridge, and to give some more context to this conversation on X.

To state the current situation:

This repo aims to port brainrender to napari. However, there are some outstanding issues:

napari-vedo-bridge seems like it could potentially help in a few ways:

We should look into napari-vedo-bridge more and see how we could best leverage it.

jo-mueller commented 1 month ago

Hi @adamltyson ,

thanks for your interest in the vedo-bridge! As discussed on Twitter (I'm stubborn😅) , turning the current cutter widget into a more abstract Baseclass and a more advanced cutting tool would probably help others to make use of the vedo rendering inside napari more easily.

The VedoViewerBase would probably have to expose functionalities to retrieve data from napari and add it to the vedo viewer and vice versa - anything else? 🤔

Other widgets built on top would just have to add their own buttons to the widget to add more functionalities to it.

Allow vedo-based mesh manipulation within napari

Where this is concerned: I am writing up a wrapper for pretty much every vedo function inside napari these days - maybe that could also make mesh interaction a bit more powerful. There is already napari-process-points-and-surfaces, but it's not very actively maintained these days. If you are interested we could collaborate a bit on the napari-vedo-bridge - a broader user base would likely make it easier to maintain in the long run.

adamltyson commented 1 month ago

Thanks for your reply @jo-mueller. That all sounds great on our side. Visualisation isn't a top priority for us now, but it likely will be soon, alongside interactive processing of meshes. We'll make sure to contribute to your tool where possible and avoid reinventing the wheel.

jo-mueller commented 1 month ago

Hi @adamltyson ,

I released the napari-vedo-bridge 0.2.0 earlier. It comes with some mesh processing functions as well as a ore basic vedo/vtk mesh visualization widget that should be a bit easier to copy/extent. Hope it's of use to you and feel free to open any issues regarding improvements :)

adamltyson commented 1 month ago

Thanks @jo-mueller, will take a look!