depend non-optionally on latest napari - Githubissues

brainglobe / brainrender-napari

A napari plugin to render BrainGlobe atlases and associated data as layers.

BSD 3-Clause "New" or "Revised" License

18 stars 1 forks source link

depend non-optionally on latest napari #59

Closed alessandrofelder closed 11 months ago

alessandrofelder commented 11 months ago

Description

What is this PR

[ ] Bug fix
[ ] Addition of a new feature
[x] Other

Why is this PR needed? Older versions of napari have a bug that affects this repo.

What does this PR do? Moves napari to non-optional dependencies, and requires napari >=0.4.18

References

Closes #35

How has this PR been tested?

I've been running tests locally on napari 0.4.18 RCs for a while, and presumably the CI too (since the release of 0.4.18 a few weeks ago)

Is this a breaking change?

In the sense that this may not be installable on older napari version now, yes.

Does this PR require an update to the documentation?

Nope.

Checklist:

[x] The code has been tested locally
[n/a] Tests have been added to cover all new functionality (unit & integration)
[n/a] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit