brainglobe / brainrender-napari

A napari plugin to render BrainGlobe atlases and associated data as layers.
BSD 3-Clause "New" or "Revised" License
18 stars 1 forks source link

add name to structure tree view #60

Closed alessandrofelder closed 10 months ago

alessandrofelder commented 11 months ago

Description

What is this PR

Why is this PR needed? We'd like to see the names of the structures in the tree view, not just the acronyms

What does this PR do? Alternative, simpler-to-implement solution to a toggle between structure acronyms and names: acronyms are always shown, and names can be shown/hidden with a checkbox.

For the more difficult implementation

References

Closes #47

How has this PR been tested?

Tests for the new checkbox functionality have been added.

Is this a breaking change?

Nope.

Does this PR require an update to the documentation?

Nope

Checklist:

alessandrofelder commented 10 months ago

needs to be rebased onto #67

[Edit] done :heavy_check_mark:

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19% :tada:

Comparison is base (adf5ce6) 97.32% compared to head (21ad9eb) 97.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== + Coverage 97.32% 97.51% +0.19% ========================================== Files 7 7 Lines 299 322 +23 ========================================== + Hits 291 314 +23 Misses 8 8 ``` | [Files Changed](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [brainrender\_napari/brainrender\_widget.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL2JyYWlucmVuZGVyX3dpZGdldC5weQ==) | `100.00% <100.00%> (ø)` | | | [brainrender\_napari/widgets/structure\_view.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL3dpZGdldHMvc3RydWN0dXJlX3ZpZXcucHk=) | `93.33% <100.00%> (+0.41%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 10 months ago

Sorry just seen the issues tracking progress on this.