minor improvement to tests and CI

alessandrofelder commented 10 months ago

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed? Windows CI is taking 1h+

What does this PR do?

Includes the fish atlas in the GH actions cache, so we can test adding an additional reference more quickly
adds an additional assertion about the selected atlas in additional reference tests.
Cancelled CI runs may keep an atlas.tar.gz file hanging around if a workflow run is interrupted before an atlas could be downloaded and extracted. This PR excludes this file from being cached so this can't mess with subsequent runs.
disables cross OS caching that was not working on Windows.

References

Closes #74

How has this PR been tested?

Tests now take <5 mins on all OS.

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Nope

Checklist:

[n/a] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[n/a] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.22% :tada:

Comparison is base (7121f2d) 96.72% compared to head (964f10f) 96.95%. Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 96.72% 96.95% +0.22% ========================================== Files 7 7 Lines 305 328 +23 ========================================== + Hits 295 318 +23 Misses 10 10 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/75/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 10 months ago

Tests now take <5 mins on all OS.

Lies! Screenshot from 2023-08-24 17-16-03

alessandrofelder commented 10 months ago

Weird. Seems to fluctuate. The <5 min claim holds for this run, (which differs only in a change in a comment and the sanity check step, I think.) :shrug:

brainglobe / brainrender-napari