brainglobe / brainrender-napari

A napari plugin to render BrainGlobe atlases and associated data as layers.
BSD 3-Clause "New" or "Revised" License
19 stars 1 forks source link

improve 3D brain region view tooltip #83

Closed alessandrofelder closed 1 year ago

alessandrofelder commented 1 year ago

Description

What is this PR

Why is this PR needed? It may not be obvious that meshes are only really visible in a 3D view.

What does this PR do? Specifies the above in the mesh tooltip.

References

Closes #81 (in conjunction with docs improvements and #82 )

How has this PR been tested?

Tests pass locally and on CI. test_brainrender_widget.test_structure_view_tooltip() has been adapted to include additional keywords for the expanded tooltip.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (767772f) 97.05% compared to head (52f4822) 97.05%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #83 +/- ## ======================================= Coverage 97.05% 97.05% ======================================= Files 7 7 Lines 339 339 ======================================= Hits 329 329 Misses 10 10 ``` | [Files Changed](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [brainrender\_napari/brainrender\_widget.py](https://app.codecov.io/gh/brainglobe/brainrender-napari/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-YnJhaW5yZW5kZXJfbmFwYXJpL2JyYWlucmVuZGVyX3dpZGdldC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.