brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
547 stars 77 forks source link

BUG brainrender scene fails to display (apart from inset) #240

Closed alessandrofelder closed 11 months ago

alessandrofelder commented 1 year ago

Describe the bug Running a simple test script (or any of the examples) doesn't display and just stays black.

To Reproduce

Then tell us the steps to reproduce the behavior:

Expected behavior A reasonable looking 3d scene with the allen mouse atlas (25 um) in the brainrender style should appear

Screenshots Screenshot from 2023-08-04 16-10-56 See also discussion on image.sc

alessandrofelder commented 1 year ago

Naive commenting out of lines 13 and 23

vsettings.useFXAA = True
vsettings.useDepthPeeling = True

in https://github.com/brainglobe/brainrender/blob/a14ead80c1dbc75f20a145a49394dc467c4f7bf1/brainrender/settings.py seems to fix this for me, but I worry about breaking things elsewhere and don't know why this happens yet!

alessandrofelder commented 11 months ago

Setting vsetting.use_fxaa = False in settings.py fixes this for me in a [dev] installation of the current mega-fix branch.

Initial investigation suggests this is an nvidia anti-aliasing setting, so it looks like this is the result of an interplay between vedo and me not having my GPU set up correctly?

adamltyson commented 11 months ago

Initial investigation suggests this is an nvidia anti-aliasing setting, so it looks like this is the result of an interplay between vedo and me not having my GPU set up correctly?

Can you reproduce on your macbook?

marcomusy commented 11 months ago

I think these 2 flags should be set to false by default as they are machine hence user-dependent.

alessandrofelder commented 11 months ago

Fixed by #283