brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
540 stars 75 forks source link

Fix windows install #263

Closed alessandrofelder closed 10 months ago

alessandrofelder commented 10 months ago

Description

What is this PR

Why is this PR needed?

CI installation fails on Windows.

What does this PR do?

Hard-codes h5py<=3.9 dependency.

References

temporary fix #258 - don't support python 3.11 for Windows GUI for now.

How has this PR been tested?

CI install is successful (although tests fail)

Is this a breaking change?

Nope.

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f638888) 67.86% compared to head (94213a1) 67.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mega-fix #263 +/- ## ========================================= Coverage 67.86% 67.86% ========================================= Files 26 26 Lines 1195 1195 ========================================= Hits 811 811 Misses 384 384 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.