brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
540 stars 75 forks source link

Install HDF5 for mac CI #265

Closed alessandrofelder closed 10 months ago

alessandrofelder commented 10 months ago

Description

What is this PR

Why is this PR needed?

Installation of brainrender fails on MacOS.

What does this PR do?

Adds a step to the Mac CI that brew installs HDF5.

References

temporary fix for #259

How has this PR been tested?

Looking at CI output.

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Yes - we will document any new things that users need to do to install on Mac (If we can't avoid this).

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f638888) 67.86% compared to head (218c0ce) 67.86%. Report is 1 commits behind head on mega-fix.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mega-fix #265 +/- ## ========================================= Coverage 67.86% 67.86% ========================================= Files 26 26 Lines 1195 1195 ========================================= Hits 811 811 Misses 384 384 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.