brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
547 stars 77 forks source link

Compatibility with vedo 2023.5.0 #277

Closed IgorTatarnikov closed 11 months ago

IgorTatarnikov commented 11 months ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

This PR addresses any changed to the API made in vedo 2023.5.0.

Why is this PR needed?

vedo 2023.5.0 was released.

References

261

How has this PR been tested?

All tests pass locally, all examples apart from examples/streamlines.py run.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Checklist:

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9a24de2) 67.86% compared to head (cf07e74) 72.44%. Report is 7 commits behind head on mega-fix.

Files Patch % Lines
brainrender/actors/cylinder.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## mega-fix #277 +/- ## ============================================ + Coverage 67.86% 72.44% +4.57% ============================================ Files 26 26 Lines 1195 1194 -1 ============================================ + Hits 811 865 +54 + Misses 384 329 -55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 11 months ago

As I presume you've seen, the new way to set the color mode (?) can be gleaned from this vedo example - no idea whether we want to/need/should support this (@adamltyson ?)

No idea tbh

alessandrofelder commented 11 months ago

No idea tbh

I'd suggest leaving it out then until a user asks for the functionality, but also happy with an additional mode argument for if we wanna support it - no strong opinion. This can be merged once you're happy with it @IgorTatarnikov - I am.