Closed IgorTatarnikov closed 11 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
9a24de2
) 67.86% compared to head (cf07e74
) 72.44%. Report is 7 commits behind head on mega-fix.
Files | Patch % | Lines |
---|---|---|
brainrender/actors/cylinder.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As I presume you've seen, the new way to set the color mode (?) can be gleaned from this vedo example - no idea whether we want to/need/should support this (@adamltyson ?)
No idea tbh
No idea tbh
I'd suggest leaving it out then until a user asks for the functionality, but also happy with an additional mode
argument for if we wanna support it - no strong opinion. This can be merged once you're happy with it @IgorTatarnikov - I am.
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
This PR addresses any changed to the API made in vedo 2023.5.0.
Why is this PR needed?
vedo 2023.5.0 was released.
References
261
How has this PR been tested?
All tests pass locally, all examples apart from
examples/streamlines.py
run.Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Checklist: