All examples rendering correctly with vedo 2023.5.0

brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.

https://brainglobe.info/documentation/brainrender/index.html

BSD 3-Clause "New" or "Revised" License

538 stars 75 forks source link

All examples rendering correctly with vedo 2023.5.0 #281

Closed IgorTatarnikov closed 9 months ago

IgorTatarnikov commented 9 months ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed? Several example files were either not running, or not rendering correctly (misaligned with the root mesh)

What does this PR do? Ensure all example scripts (except streamlines.py due to missing data) run and render correctly.

References

closes #251 closes #261

Checklist:

[x] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[x] The code has been formatted with pre-commit

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e6df766) 81.15% compared to head (b3fa6eb) 86.39%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## mega-fix #281 +/- ## ============================================ + Coverage 81.15% 86.39% +5.23% ============================================ Files 26 26 Lines 1194 1205 +11 ============================================ + Hits 969 1041 +72 + Misses 225 164 -61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

IgorTatarnikov commented 9 months ago

All done! All resources are now in brainrender/resources. Any example or test that was using the data no uses importlib.resources to fetch the data.