Closed alessandrofelder closed 9 months ago
Would it not be better to just change the default so that users can change this within brainrender settings?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
69a2aea
) 86.39% compared to head (b304bc2
) 86.39%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Would it not be better to just change the default so that users can change this within brainrender settings?
Sure, makes it more explicit what we expect users might want to change (think they can change everything anyway though, if they know what settings vedo has).
Description
What is this PR
Why is this PR needed? Brainrender examples don't render correctly on some machines - see #240 and related forum discussion
What does this PR do? Removes the explicit setting of a
vedo
setting that messes with rendering.References
Closes #240
How has this PR been tested?
Local running of
Is this a breaking change?
Yes, if anyone was relying on
use_FXAA
being set to true.Does this PR require an update to the documentation?
Don't think this was documented anywhere in the first place, so not specifically?
Checklist: