brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Remove setting of user-dependent FXAA vedo setting #283

Closed alessandrofelder closed 9 months ago

alessandrofelder commented 9 months ago

Description

What is this PR

Why is this PR needed? Brainrender examples don't render correctly on some machines - see #240 and related forum discussion

What does this PR do? Removes the explicit setting of a vedo setting that messes with rendering.

References

Closes #240

How has this PR been tested?

Local running of

import brainrender
scene=brainrender.Scene(atlas_name="allen_mouse_25um")
scene.render()

Is this a breaking change?

Yes, if anyone was relying on use_FXAA being set to true.

Does this PR require an update to the documentation?

Don't think this was documented anywhere in the first place, so not specifically?

Checklist:

adamltyson commented 9 months ago

Would it not be better to just change the default so that users can change this within brainrender settings?

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (69a2aea) 86.39% compared to head (b304bc2) 86.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mega-fix #283 +/- ## ========================================= Coverage 86.39% 86.39% ========================================= Files 26 26 Lines 1205 1205 ========================================= Hits 1041 1041 Misses 164 164 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alessandrofelder commented 9 months ago

Would it not be better to just change the default so that users can change this within brainrender settings?

Sure, makes it more explicit what we expect users might want to change (think they can change everything anyway though, if they know what settings vedo has).