brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Switch PySide2 for PyQt5 #287

Closed IgorTatarnikov closed 9 months ago

IgorTatarnikov commented 9 months ago

Before submitting a pull request (PR), please read the contributing guide.

Description

Switched out PySide2 for PyQt5 in the dev dependencies. This allows CI to run using windows python 3.11.

What is this PR

Why is this PR needed? There is no versions of PySide2 that's compatible with python 3.11 and Windows.

What does this PR do? Changed PySide2 to PyQt5

References

Closes #258

How has this PR been tested?

Tested locally and on CI

Is this a breaking change?

No

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a5af51c) 86.39% compared to head (942d603) 86.39%. Report is 11 commits behind head on mega-fix.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mega-fix #287 +/- ## ========================================= Coverage 86.39% 86.39% ========================================= Files 26 26 Lines 1205 1205 ========================================= Hits 1041 1041 Misses 164 164 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.