various (small) improvements

marcomusy commented 9 months ago

Description

What is this PR

camera.py and cameras.py: rename old 'clippingRange' -> 'clipping_range' rename old 'focalPoint' -> 'focal_point'
render.py: remove import matplotlib.pyplot as plt, this looks like a genuine bug
correct close() method accordingly
add actor._mesh.transform = None in if isinstance(actor._mesh, VedoVolume) as future vedo release will need this
settings.py: set WHOLE_SCREEN = False as default, avoid setting size='full' as this is poorly dealt with in vtk
fix output path in examples/screenshot.py and video.py
pyproject.toml: a newer version of "morphapi>=0.2" seems to be needed

How has this PR been tested?

Tested on the examples

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

[ ] The code has been tested locally
[ ] Tests have been added to cover all new functionality (unit & integration)
[ ] The documentation has been updated to reflect any changes

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (19350ce) 86.18% compared to head (97e184e) 86.07%.

Files	Patch %	Lines
brainrender/camera.py	88.88%	1 Missing :warning:
brainrender/render.py	83.33%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #291 +/- ## ========================================== - Coverage 86.18% 86.07% -0.11% ========================================== Files 26 26 Lines 1209 1214 +5 ========================================== + Hits 1042 1045 +3 - Misses 167 169 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alessandrofelder commented 9 months ago

Opened #294 for test that still doesn't pass - may well be the data we regress against in that test.

brainglobe / brainrender