brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Fixed bug related to issue #293, amended tests to check in the future #296

Closed IgorTatarnikov closed 9 months ago

IgorTatarnikov commented 9 months ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR Addresses #293, removes the z mirror and adds tests for this bug in the future.

Why is this PR needed?

What does this PR do?

References

Closes #293

How has this PR been tested?

Tests added to check for this issue.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7d00370) 86.24% compared to head (a1c23fe) 86.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ========================================== - Coverage 86.24% 86.23% -0.02% ========================================== Files 26 26 Lines 1214 1213 -1 ========================================== - Hits 1047 1046 -1 Misses 167 167 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.