brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Fix rotation bug when exproting to html #318

Closed IgorTatarnikov closed 8 months ago

IgorTatarnikov commented 8 months ago

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

Why is this PR needed? The meshes were mirrored when exporting to HTML, see #315.

What does this PR do? Provides already transformed meshes to be rendered by k3d.

References

315

How has this PR been tested?

The probe tracks were exported to HTML and visually inspected.

All other examples render correctly, and all tests pass.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (52b1ec0) 86.39% compared to head (19e1065) 86.39%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #318 +/- ## ======================================= Coverage 86.39% 86.39% ======================================= Files 26 26 Lines 1213 1213 ======================================= Hits 1048 1048 Misses 165 165 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.