Closed IgorTatarnikov closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.47%. Comparing base (
f3103ba
) to head (0fdfcce
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed? Currently we only support saving screenshots as
.png
.vedo
seems to support.pdf
,.eps
,.jpg
, and.svg
. I don't see why we couldn't as well!What does this PR do? Adds a check to make sure the suffix of the file name is supported before passing it back to
vedo
. If there's no suffix, or it's not supported it just saves it as a.png
.References
Closes #340
How has this PR been tested?
Tested locally
Is this a breaking change?
No
Does this PR require an update to the documentation?
Yes, need to document the supported file formats. There are seems to be some weird behaviour when saving as
.eps
or.svg
where they're written as.eps.gz
or.svg.gz
and have to be uncompressed first.Checklist: