search

brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Add screenshot tests #351

Closed adamltyson closed 3 months ago

adamltyson commented 3 months ago

I've raised this PR to investigate #338. The test suggest that there is a problem specifically with Linux. Images are generated, but it's not what it's meant to be.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.31%. Comparing base (48f655f) to head (4fe88ec).

:exclamation: Current head 4fe88ec differs from pull request most recent head cbeee3b

Please upload reports for the commit cbeee3b to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 86.96% 86.31% -0.66% ========================================== Files 27 27 Lines 1220 1220 ========================================== - Hits 1061 1053 -8 - Misses 159 167 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 3 months ago

I've had to limit one of the tests due to #357. I can't work out the problem, so I'm leaving this PR as it is for now. I still think it's worth merging as it improves the screenshot tests slightly.

adamltyson commented 3 months ago

tests are failing because neuromorpho is down again.