search

brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Update supported Python versions #363

Closed adamltyson closed 3 months ago

adamltyson commented 3 months ago

Tests seem to be failing for the usual neuromorpho issue. Should we think about disabling the tests for this, or just removing the features that rely on it totally?

alessandrofelder commented 3 months ago

Hopefully #366 will help here - is that ready for review yet @IgorTatarnikov ?

IgorTatarnikov commented 3 months ago

It's ready, I had to fiddle with the screenshot example. It seems that when we run the example scripts during testing they pollute the global settings so the background was set to [0.22, 0.22, 0.22] if the full test suite was run first causing the screenshot similarity index to be low.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.98%. Comparing base (767f5d1) to head (fac475c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #363 +/- ## ======================================= Coverage 86.98% 86.98% ======================================= Files 27 27 Lines 1214 1214 ======================================= Hits 1056 1056 Misses 158 158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 3 months ago

Tests finally pass :tada: