Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
[x] Bug fix
[ ] Addition of a new feature
[ ] Other
Why is this PR needed?
The camera position was not set properly when passing a custom camera dict to scene.render.
What does this PR do?
Passes resetcam=False back to plotter.show. Without this the camera position was being adjusted in the plotter.show method.
References
Closes #360
How has this PR been tested?
All tests pass, running the workflow as stated in the bug report also works. Can adjust the camera and position, save the output from Shift+C, and recreate the exact camera position with a dict.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist:
[x] The code has been tested locally
[ ] Tests have been added to cover all new functionality (unit & integration)
[ ] The documentation has been updated to reflect any changes
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed? The camera position was not set properly when passing a custom camera dict to
scene.render
.What does this PR do? Passes
resetcam=False
back toplotter.show
. Without this the camera position was being adjusted in theplotter.show
method.References
Closes #360
How has this PR been tested?
All tests pass, running the workflow as stated in the bug report also works. Can adjust the camera and position, save the output from Shift+C, and recreate the exact camera position with a dict.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: