search

brainglobe / brainrender

a python based software for visualization of neuroanatomical and morphological data.
https://brainglobe.info/documentation/brainrender/index.html
BSD 3-Clause "New" or "Revised" License
538 stars 75 forks source link

Remove unused camera printing code and make camera parameters consistent #365

Closed adamltyson closed 3 months ago

adamltyson commented 3 months ago

Reviewing #360 I noticed that the camera parameters that brainrender checks don't exactly match the parameters that the user that it must have. This corrects that.

I then noticed that the code that prints the camera position isn't actually used (vedo uses the same keyboard shortcut), so I removed it. I raised https://github.com/marcomusy/vedo/pull/1134 to correct the parameters that are printed.

adamltyson commented 3 months ago

FYI the tests are failing because of the neuromorpho issue, but also because of an issue that's fixed, but not yet released in vedo.