Closed IgorTatarnikov closed 3 weeks ago
Attention: Patch coverage is 80.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 88.06%. Comparing base (
9cd07c8
) to head (89ffcaf
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
brainrender/scene.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @IgorTatarnikov! This looks good to me, but I won't review until it's marked as "ready for review".
I checked, and it also fixes this image.sc issue.
I unmarked it because this approach fails with the new axolotl atlas, so I was going to do some more investigating!
This fix works appropriately if the axolotl and other asymmetric atlases have the correct metadata tag. I've opened https://github.com/brainglobe/brainglobe-atlasapi/issues/359 to track this issue. However, I believe this PR is ready to go in.
Great, thanks @IgorTatarnikov. I'll merge this then release.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed? See the discussion in https://github.com/brainglobe/brainglobe-atlasapi/issues/330
What does this PR do? If the atlas is marked as symmetrical in the metadata the midpoint is now calculated by taking the mean of the root mesh bounds for each axis. If the atlas isn't marked as symmetrical the previous behaviour is maintained.
References
https://github.com/brainglobe/brainglobe-atlasapi/issues/330
How has this PR been tested?
Tested locally by visual inspection. For an asymmetric atlas:
For symmetric atlases:
Is this a breaking change?
No
Checklist: