Closed alessandrofelder closed 1 year ago
Note that CI fails in expected way, ensuring our tests now can reproduce #158.
@alessandrofelder would it be worth renaming the directory containing the new test data? The dataset label doesn't mean much to anyone other than me. Maybe something like structure_split_test
, then just add a note (maybe a txt file) to highlight which dataset it's from for our records?
Thanks for your comments, both!
Re test data, I had that thought too, but decided against it as
But maybe it's worth reconsidering this decision?
We definitely want to be using pooch
soon!
👍 sounds good re. test data
Nice - hopefully code coverage should increase when this commit runs on the main
branch!
Description
This PR adds
an integration smoke test and additional test data (created from a real-life dataset) to reproduce #158 and cover our structure splitting code with the tests.
a refactor to consistently use
np.ndarray
s and other numba-suitable refactoring in the structure splitting code.[ ] Bug fix
[x] Addition of a new feature
[ ] Other
Why is this PR needed?
Our tests don't currently cover the case where cell detection requires structure splitting.
What does this PR do?
See description.
References
Closes #166, closes #158, closes #159
How has this PR been tested?
Run tests locally and on CI.
Does this PR require an update to the documentation?
New test and fixtures have docstrings, test data documented in docstring of new testing module.
Checklist: