brainglobe / cellfinder-core

Standalone cellfinder cell detection algorithm
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
19 stars 16 forks source link

[BUG] `conda install cellfinder-core==0.4.0` does not allow `pip` to read version correctly. #179

Closed willGraham01 closed 1 year ago

willGraham01 commented 1 year ago

(Making myself an issue to track solutions/experiments so far)

Describe the bug In a clean conda/mamba environment, running

conda install -y cellfinder-core==0.4.0
conda list cellfinder-core

will successfully install cellfinder-core version 0.4.0. But running

pip show cellfinder-core

will return a version of 0.0.0.

This means that any conda install that requires cellfinder-core will fail the pip check step of the testing phase. See for example the BrainGlobe package recipe.

On the other hand,

pip install cellfinder-core==0.4.0

will get pip show and conda list to correctly show version 0.4.0.

To Reproduce See above.

Expected behaviour pip show (and pip list, pip check) should correctly identify version 0.4.0.

Computer used (please complete the following information):

willGraham01 commented 1 year ago

This is not fixed by the dynamic versioning fix in v0.4.1. conda-installing this package still results in pip picking up a version of 0.0.0.

adamltyson commented 1 year ago

But the new version isn't on conda forge yet?

willGraham01 commented 1 year ago

It's reported in the "successful" build: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=732104&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=652

Although v0.4.1 does fix the version when queried within Python:

> import cellfinder_core as cc
> cc.__version__
'0.4.1'
>