brainglobe / cellfinder-core

Standalone cellfinder cell detection algorithm
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
19 stars 16 forks source link

Tensorflow as optional dependency? #185

Closed willGraham01 closed 1 year ago

willGraham01 commented 1 year ago

Description

What is this PR

Why is this PR needed? This resolves the tensorflow problem as listed on this BrainGlobe repository issue.

Worth looking at the alternative solution proposed there too.

What does this PR do? Makes tensorflow an optional dependency and include-guards all tensorflow-functionality that cellfinder-core uses in the event that the user does not have tensorflow installed.

(Although having examined this, it looks like this means that cellfinder-core simply doesn't have any functionality to offer).

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Is this a breaking change?

Yes - users now need to ensure they have tensorflow pre-installed in their environment, or explicitly request it to be fetched along with cellfinder-core when they install.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist: