Closed willGraham01 closed 1 year ago
What is this PR
Why is this PR needed? See https://github.com/brainglobe/BrainGlobe/issues/27 - this PR is for conda-forge compatibility reasons.
conda-forge
What does this PR do? This PR forbids the import of cellfinder_core when tensorflow is not installed.
cellfinder_core
tensorflow
Note that we do not need to remove tensorflow from the pyproject.toml dependencies - these are read only by pip and not by conda.
pyproject.toml
pip
conda
Resolves step 1 of this issue.
Local testing of pip package install:
$ conda activate cellfinder (cellfinder) $ pip install . (cellfinder) $ python >> import cellfinder_core # All good >> exit() (cellfinder) $ pip uninstall tensorflow (cellfinder) $ python >> import cellfinder_core # Throws expected error (cellfinder) $ pip install tensorflow (cellfinder) $ python >> import cellfinder_core # All good again >> exit()
No. New version, PyPI upload, and conda-forge recipe required though.
Updates README to explain that the conda-install will not fetch tensorflow, this will have to be done by the user.
Requires a change on brainglobe-meta repository.
brainglobe-meta
Description
What is this PR
Why is this PR needed? See https://github.com/brainglobe/BrainGlobe/issues/27 - this PR is for
conda-forge
compatibility reasons.What does this PR do? This PR forbids the import of
cellfinder_core
whentensorflow
is not installed.Note that we do not need to remove
tensorflow
from thepyproject.toml
dependencies - these are read only bypip
and not byconda
.References
Resolves step 1 of this issue.
How has this PR been tested?
Local testing of
pip
package install:Is this a breaking change?
No. New version, PyPI upload, and conda-forge recipe required though.
Does this PR require an update to the documentation?
Updates README to explain that the conda-install will not fetch tensorflow, this will have to be done by the user.
Requires a change on
brainglobe-meta
repository.Checklist: