MANIFEST only necessary files for package install

[willGraham01]

Description

What is this PR

• [ ] Bug fix
• [x] Addition of a new feature
• [ ] Other

Why is this PR needed?

We currently ship the benchmarks and tests with the source distribution. We shouldn't do this.

What does this PR do?

• Tells the MANIFEST.in to ignore the unnecessary directories.
• Adds a MANIFEST check to the CI, to bring it in line with other BrainGlobe packages.

References

• Closes #193

How has this PR been tested?

• CI tests pass : THERE WAS A BUG IN TOX-GH-ACTIONS
• Manual python -m build followed by inspection of the source tar.gz confirm source contents are as expected.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

• [x] The code has been tested locally
• [x] Tests have been added to cover all new functionality (unit & integration)
• [x] The documentation has been updated to reflect any changes
• [x] The code has been formatted with pre-commit

[alessandrofelder]

LGTM!

For the record, some thinking and discussion with @lauraporta that went into this.

I had second thoughts about removing the tests from the package and read an online discussion (key excerpts below)

My (personal) view is that I want the sdist so that I can build the project on an otherwise-unsupported environment, and I can view the source code of the project (even though pure Python wheels include the source, it’s not in “buildable form”).

and

If the project is non-trivial, you probably need to run the tests to ensure that your build is functional, no?

but given our tests are useless with the the biggish test data in our repo, and we really don't want to ship the test data, let's remove them entirely. Users that want to run the tests on a source install can always clone and install from the repo 🤷