Closed alessandrofelder closed 1 year ago
My guess is this is because our guard checks for the existence of a tensorflow package, but TensorFlow is called tensorflow-macos on Macs.
Does TensorFlow not exist on macOS? I assumed tensorflow-macos
was the version compiled to use the apple silicon GPU.
I guess we need:
I should have been more precise: on Apple Silicon, tensorflow
only exists from 2.13 but our current pyproject.toml
requires tensorflow-macos<2.12
for Silicon chips?
On my Apple M2 at least, running pip install "tensorflow<2.12"
gives
ERROR: Could not find a version that satisfies the requirement tensorflow<2.12 (from versions: 2.13.0rc0, 2.13.0rc1, 2.13.0rc2, 2.13.0)
ERROR: No matching distribution found for tensorflow<2.12
Also, to be clear, tensorflow-macos
install and works fine. It's just the guard that's the problem!
Describe the bug
pytest
doesn't work on `pip install -e ".[dev]" in clean conda env. I getMy guess is this is because our guard checks for the existence of a
tensorflow
package, but TensorFlow is calledtensorflow-macos
on Macs.I could be missing something though. I'm surprised we haven't noticed this elsewhere 🤔
To Reproduce See above:
pip install -e ".[dev]"
in clean conda env on Apple Silicon.Expected behaviour
pytest
should run the tests out-of-the box in a dev environmentLog file n/a
Screenshots n/a
Computer used (please complete the following information):