possible fix for mac error

alessandrofelder commented 1 year ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed? I had some troubles installing a clean development environment on my macbook.

What does this PR do? extends the tensorflow guard to include tensorflow-macos.

References

Closes brainglobe/cellfinder-core#199

How has this PR been tested?

Works locally for me?

Is this a breaking change?

Nope

Does this PR require an update to the documentation?

Nope

Checklist:

[x] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[x] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

alessandrofelder commented 1 year ago

I think having that extra workflow as a test is a great idea!

alessandrofelder commented 1 year ago

Test failure seems genuine but I don't believe that it would be caused by any changes in this PR (the tests run on ubuntu-latest...).

Yea, the test fails in the same way in a completely different PR too. And it's the cellfinder, not the cellfinder-core test that fails. Should be addressed in a separate PR? I've opened brainglobe/cellfinder#276 for this

brainglobe / cellfinder-core