CI Check against `tensorflow` include guard

willGraham01 commented 1 year ago

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

[ ] Bug fix
[x] Addition of a new feature
[ ] Other

Why is this PR needed?

Tests the include-guard that denies use of the tools when tensorflow is not available.

What does this PR do?

Adds a short check to make sure that the tensorflow include guard is behaving itself on ubuntu and macOS.

pip install -e . should successfully fetch tensorflow and allow import.
If tensorflow is not installed, importing the module should fail. Conditions for this test are achieved by having pip uninstall tensorflow.

References

Closes brainglobe/cellfinder-core#203

How has this PR been tested?

Locally running the commands produces the outcomes that are checked against. New workflow has been introduced to check the results are as expected on CI.

Is this a breaking change?

No

Does this PR require an update to the documentation?

Checklist:

[x] The code has been tested locally
[x] Tests have been added to cover all new functionality (unit & integration)
[ ] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

willGraham01 commented 1 year ago

cellfinder CI checks still fail as per brainglobe/cellfinder#276, but this PR is independent of what's causing that.

adamltyson commented 1 year ago

I think (thought?) we had an issue to expand CI to new Macs, but I can't find it for the life of me. Maybe we should open another one?

https://github.com/brainglobe/cellfinder-core/pull/141

brainglobe / cellfinder-core