brainglobe / cellfinder-napari

Efficient cell detection in large images using cellfinder in napari
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Use official scrollable widget #136

Closed adamltyson closed 2 years ago

adamltyson commented 2 years ago

Addresses https://github.com/brainglobe/cellfinder/issues/341 & https://github.com/brainglobe/cellfinder-napari/issues/122.

Thanks to @dstansby's hard work :pray:

Closing brainglobe/cellfinder-napari#135 in favour of this as I messed up the Git history.

deprecated-napari-hub-preview-bot[bot] commented 2 years ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/brainglobe/cellfinder-napari/136 Updated: 2022-10-14T14:39:24.426864

codecov[bot] commented 2 years ago

Codecov Report

Base: 95.42% // Head: 95.40% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (4c87fa2) compared to base (e2d73a3). Patch has no changes to coverable lines.

:exclamation: Current head 4c87fa2 differs from pull request most recent head 5ba2b6f. Consider uploading reports for the commit 5ba2b6f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main brainglobe/cellfinder-napari#136 +/- ## ========================================== - Coverage 95.42% 95.40% -0.02% ========================================== Files 17 17 Lines 808 805 -3 ========================================== - Hits 771 768 -3 Misses 37 37 ``` | [Impacted Files](https://codecov.io/gh/brainglobe/cellfinder-napari/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [cellfinder\_napari/detect/detect.py](https://codecov.io/gh/brainglobe/cellfinder-napari/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-Y2VsbGZpbmRlcl9uYXBhcmkvZGV0ZWN0L2RldGVjdC5weQ==) | `93.10% <ø> (-0.34%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adamltyson commented 2 years ago

Maybe not. This doesn't work for me locally anymore ...

adamltyson commented 2 years ago

For some reason this is still required. I'd assumed scrollable=True should suffice.

    scroll = QScrollArea()
    scroll.setWidget(widget._widget._qwidget)
    widget._widget._qwidget = scroll
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adamltyson commented 2 years ago

This is failing on some Python versions, but with a known napari issue (E ModuleNotFoundError: No module named 'imageio_ffmpeg') so merging anyway. Should be fixed with the next release of napari.