search

brainglobe / cellfinder-napari

Efficient cell detection in large images using cellfinder in napari
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
23 stars 6 forks source link

Update yaml filter #152

Closed adamltyson closed 1 year ago

adamltyson commented 1 year ago

The "y?ml" syntax doesn't seem to be supported by napari.

adamltyson commented 1 year ago

And specifying .yml for now is fine, because that's what cellfinder produces (i.e. not .yaml)

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/brainglobe/cellfinder-napari/152 Created: 2023-03-09T16:29:35.002542

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef1ef89) 95.35% compared to head (f0799f6) 95.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ======================================= Coverage 95.35% 95.35% ======================================= Files 17 17 Lines 797 797 ======================================= Hits 760 760 Misses 37 37 ``` | [Impacted Files](https://codecov.io/gh/brainglobe/cellfinder-napari/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe) | Coverage Δ | | |---|---|---| | [cellfinder\_napari/train/train\_containers.py](https://codecov.io/gh/brainglobe/cellfinder-napari/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe#diff-Y2VsbGZpbmRlcl9uYXBhcmkvdHJhaW4vdHJhaW5fY29udGFpbmVycy5weQ==) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=brainglobe)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alessandrofelder commented 1 year ago

Something weird seems to happen on Ubuntu CI : an external action crashing during a cleanup step?

Tests pass, and change is reasonable, so I'll merge.