brainglobe / cellfinder-napari

Efficient cell detection in large images using cellfinder in napari
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
23 stars 6 forks source link

Tests are failing #157

Closed adamltyson closed 1 year ago

adamltyson commented 1 year ago

See https://github.com/brainglobe/cellfinder-napari/actions/runs/5312974479. Something to do with multiprocessing.

alessandrofelder commented 1 year ago

Initial investigation suggests to me that we are spawning a multiprocessing thread pool with 0 processes on the GH actions runs 🤔 The GH actions runners have two cores, and I suspect for the failing test

This has the consequence that we pass 0 as the number of processes to the multiprocessing.Pool constructor, which raises the Value error.

alessandrofelder commented 1 year ago

This should therefore be fixed in cellfinder_core I think, make a new release of it, and then pin cellfinder-napari to the latest release.

willGraham01 commented 1 year ago

@alessandrofelder This can be closed now with the cellfinder-core fix right? Tests are passing on main both here and in cellfinder-core.