Closed adamltyson closed 1 year ago
Initial investigation suggests to me that we are spawning a multiprocessing thread pool with 0 processes on the GH actions runs 🤔 The GH actions runners have two cores, and I suspect for the failing test
cellfinder_napari
cellfinder_core
needs at least two cores to run successfully due to this lineThis has the consequence that we pass 0 as the number of processes to the multiprocessing.Pool
constructor, which raises the Value error.
This should therefore be fixed in cellfinder_core
I think, make a new release of it, and then pin cellfinder-napari
to the latest release.
@alessandrofelder This can be closed now with the cellfinder-core fix right? Tests are passing on main
both here and in cellfinder-core
.
See https://github.com/brainglobe/cellfinder-napari/actions/runs/5312974479. Something to do with multiprocessing.