search

brainglobe / cellfinder-napari

Efficient cell detection in large images using cellfinder in napari
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Update dependency (imlib -> brainglobe-utils) #159

Closed adamltyson closed 1 year ago

adamltyson commented 1 year ago

pre-commit.ci run

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/brainglobe/cellfinder-napari/159 Updated: 2023-06-26T13:25:25.377560

adamltyson commented 1 year ago

@alessandrofelder can you check a23cfddc85003aa282dc6e10cfbb1f4af9e61ac7? I added this to please mypy, but not sure if it's valid.

adamltyson commented 1 year ago

Also tests are failing, but that's known about - #157

alessandrofelder commented 1 year ago

https://github.com/brainglobe/cellfinder-napari/commit/a23cfddc85003aa282dc6e10cfbb1f4af9e61ac7 is reasonable, I think. We call asdict (which works on data classes) on self and therefore we should specify that self is a dataclass.