search

brainglobe / cellfinder

Automated 3D cell detection in very large images
https://brainglobe.info/documentation/cellfinder/index.html
BSD 3-Clause "New" or "Revised" License
181 stars 39 forks source link

Remove x86 macOS runners from the test suite #453

Closed IgorTatarnikov closed 3 months ago

IgorTatarnikov commented 3 months ago

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

Why is this PR needed? torch is no longer supporting x86 macOS, therefore we're dropping it from our suite of tests.

What does this PR do? Removes x86 macOS runners.

Checklist:

adamltyson commented 3 months ago

Should we also get rid of the macOS x86 dependencies too? It seems weird to keep logic specific to these machines, but then not test it.

IgorTatarnikov commented 3 months ago

I can see benefits for both, leaving the line in will allow macOS x86 users to continue to install cellfinder easily, but with no guarantees of it working for us, but like you said it does feel a bit weird to specify logic but then not test it.

For fun I pulled download numbers by system and cpu and it seems like x86 mac did make up a not insignificant number of downloads (that reported the system/cpu information) but seems to be decreasing fairly drastically over the past year.

For the last year: project name cpu num_downloads
cellfinder Darwin arm64 354
cellfinder Darwin x86_64 1164
cellfinder Linux ppc64le 2
cellfinder Linux aarch64 2674
cellfinder Linux x86_64 1908
cellfinder Linux armv7l 30
cellfinder Windows AMD64 1540
cellfinder Windows   17
cellfinder     90561
For the past 6 mo: project name cpu num_downloads
cellfinder Darwin arm64 285
cellfinder Darwin x86_64 183
cellfinder Linux aarch64 2670
cellfinder Linux armv7l 10
cellfinder Linux x86_64 1174
cellfinder Windows AMD64 1040
cellfinder     49214
And 60 days: project name cpu num_downloads
cellfinder Darwin arm64 66
cellfinder Darwin x86_64 49
cellfinder Linux x86_64 313
cellfinder Linux aarch64 69
cellfinder Linux armv7l 2
cellfinder Windows AMD64 245
cellfinder     17483
adamltyson commented 3 months ago

I think we should just (unfortunately) stop supporting x86 macs in any way. We can patch things up now, but it will get harder when {other-package} drops support at some point.