ensure trained_model is a Path before calling .suffix - Githubissues

brainglobe / cellfinder

Automated 3D cell detection in very large images

https://brainglobe.info/documentation/cellfinder/index.html

BSD 3-Clause "New" or "Revised" License

181 stars 39 forks source link

ensure trained_model is a Path before calling .suffix #471

Closed alessandrofelder closed 1 week ago

alessandrofelder commented 1 week ago

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed? Latest brainmapper fails because of a missing attribute when you call it with --trained_model.

What does this PR do?

Converts trained_model to Path before calling .suffix

References

Closes #470

How has this PR been tested?

Local manual tests with brainmapper by both @JRegg66 (thank you) and myself. Local running of cellfinder tests.

Is this a breaking change?

No

Checklist:

[x] The code has been tested locally
[ ] Tests have been added to cover all new functionality (unit & integration)
- we might have caught the bug if we improved tests on the brainmapper side https://github.com/brainglobe/brainglobe-workflows/issues/70
[x] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit