brainglobe / morphapi

A lightweight python package to download neuronal morphologies
https://brainglobe.info/documentation/morphapi/index.html
MIT License
17 stars 6 forks source link

Migrate away from allensdk #69

Closed IgorTatarnikov closed 3 months ago

IgorTatarnikov commented 3 months ago

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

Why is this PR needed? We want to remove allensdk as a dependency to make upgrading to python 3.12 easy, see here

What does this PR do? Uses the Allen web API to fetch the reconstructed neurons instead of using the allensdk.

References

Closes #67

How has this PR been tested?

All tests pass, I've also tested it locally to make sure we can fetch a variety of files.

Is this a breaking change?

No, I made sure that the DataFrame stored in the neurons attribute of AllenMorphology class has the exact same format.

Does this PR require an update to the documentation?

No

Checklist:

IgorTatarnikov commented 3 months ago

Tests are currently failing due to neuromorpho being down :disappointed: