search

brainhackorg / brainmatch

Event project requirement-contributor request matching toolkit
2 stars 3 forks source link

ENH: Install package in `GitHub` testing workflow #30

Closed jhlegarreta closed 3 years ago

jhlegarreta commented 3 years ago

Install package in GitHub testing workflow.

Fixes:

>       raise FileNotFoundError('Cannot find ' + command)
E       FileNotFoundError: Cannot find compute_brainmatch_scores.py

raised for example in https://github.com/brainhackorg/brainmatch/runs/2793995399?check_suite_focus=true#step:7:76

From https://pypi.org/project/pytest-console-scripts/, pytest-console-scripts relies on the scripts being located in the path, hence it can only run the console scripts from packages that have been installed.

jhlegarreta commented 3 years ago

Cross-referencing https://github.com/brainhackorg/brainmatch/pull/29#issuecomment-858697593.

jhlegarreta commented 3 years ago

The PR needs to be merged so that the changes to the workflow file are taken into account.

Merging. Sorry for the haste.

jhlegarreta commented 3 years ago

Once merged, tests are passing: https://github.com/brainhackorg/brainmatch/actions/runs/925579496

I will bring back the pip cache step in the GitHub workflow, and probably push force rewriting the history.

jhlegarreta commented 3 years ago

Once merged, tests are passing: https://github.com/brainhackorg/brainmatch/actions/runs/925579496

I will bring back the pip cache step in the GitHub workflow, and probably push force rewriting the history.

Looks like the cache was still not containing the pytest-console-scripts https://github.com/brainhackorg/brainmatch/runs/2794912271?check_suite_focus=true#step:7:58

So leaving as it is for now.

Thanks.