search

brainhackorg / global2020

Brainhack Global 2020
https://brainhack.org/global2020/
MIT License
13 stars 14 forks source link

fix url in the load_confounds template #134

Open pbellec opened 3 years ago

pbellec commented 3 years ago

The regular expression to grab urls in the "project_url" field assumes that the URL is the last thing in that field.

This behaviour breaks the URL for the "denoising fMRI" project.

I am going to open a PR fixing this particular URL, may be worth considering getting a more robust parsing rule.

SamGuay commented 3 years ago

You are right, the regex implemented is the least robust of all time I'd say. It's done the job so far, but if anyway wants to fix it, they are welcome :smile:.

I usually fix those problems behind the scene, but didn't catch your project. Sorrry