search

brainhackorg / global2021

Website for Brainhack global 2021
https://brainhack.org/global2021/
MIT License
3 stars 11 forks source link

[INFRA] add github issue form #32

Closed Remi-Gau closed 2 years ago

Remi-Gau commented 2 years ago

fixes #5

I am using my fork as a demo (switched the default branch to show case it)

To do

decisions needed

We need to decide which items need to be filled in for people to be able to click 'submit new issue'. I am tempted to set the bar fairly high (also because sections that are not filled in do not appear in the opened issue).

Remi-Gau commented 2 years ago

@jhlegarreta @complexbrains

jhlegarreta commented 2 years ago

@Remi-Gau tremendous work. :100: to having considered the label fields and made them drop down menus. Will have a more detailed look tonight, will create the labels and start having a look at how these things can be parsed to get the relevant data.

Remi-Gau commented 2 years ago

@Remi-Gau tremendous work.

thanks

100 to having considered the label fields and made them drop down menus. Will have a more detailed look tonight, will create the labels and start having a look at how these things can be parsed to get the relevant data.

Do you think we should add special character before each label in the dropdown menus ? I think the original template used #.

This could make it easier for parsing and should not be too confusing for the users. What do you think?

jhlegarreta commented 2 years ago

Do you think we should add special character before each label in the dropdown menus ? I think the original template used #. This could make it easier for parsing and should not be too confusing for the users. What do you think?

The issue labeler action seems not to require them, so not sure why they were required. I do not see how they should help for the current form.

Remi-Gau commented 2 years ago

Ok let's proceed like that for now and see when things start catching on fire or when the wheels are coming off.

Written from my phone. Preemptive apologies for the brevity and typos.

From: Jon Haitz Legarreta Gorroño @.> Sent: Tuesday, September 28, 2021 5:19:32 PM To: brainhackorg/global2021 @.> Cc: Remi Gau @.>; Mention @.> Subject: Re: [brainhackorg/global2021] [INFRA] add github issue form (#32)

Do you think we should add special character before each label in the dropdown menus ? I think the original template used #. This could make it easier for parsing and should not be too confusing for the users. What do you think?

The issue labeler action seems not to require them, so not sure why they were required. I do not see how they should help for the current form.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/brainhackorg/global2021/pull/32#issuecomment-929330753, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVDQIN2DQEAG2OPADL7DVLUEHMIJANCNFSM5E3IPAQQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Remi-Gau commented 2 years ago

Actually the # is needed for the issue labeller and not the issue to project parsing:

https://github.com/brainhackorg/global2021/blob/main/.github/labeler.yml

jhlegarreta commented 2 years ago

Actually the # is needed for the issue labeller and not the issue to project parsing: https://github.com/brainhackorg/global2021/blob/main/.github/labeler.yml

I missed the dictionary although I think I opened the file :facepalm: . Labeling the issues was also a requirement last year so that issues could be easily filtered. I guess this is the case this year as well. Adding a heading hashtag to the drop down menus would look weird IMHO. Also, I'm not sure whether the labeler works on the YAML file. I'll create labels tonight and see if if the labeler works for an issue.

jhlegarreta commented 2 years ago

Labels created. Just in case we need them again, here they are: bhg_gh_labels.json.txt

eurunuela commented 2 years ago

These two scripts might have things in common, like getting the issues from gh. One is written in Python, the other one is a shell script. IMHO the cost of maintaining the two in non-negligible. Also taking into account #25. So it looks like one way or the other (Python vs shell) needs to be decided. Not sure if @eurunuela happens to have another proposal.

I think we should translate the shell script into Python. IMO that's the easiest way going forward considering #25. Since I wrote the pull_issues.sh script, I will open an issue in the brainmatch repository and will take care of translating it into Python.

Remi-Gau commented 2 years ago

I think we should translate the shell script into Python. IMO that's the easiest way going forward considering #25. Since I wrote the pull_issues.sh script, I will open an issue in the brainmatch repository and will take care of translating it into Python.

Agree to use Python as glue for everything.

Remi-Gau commented 2 years ago

@Remi-Gau a few thoughts after having had a look:

* To actually see if the labeler is working, we would need this to be merged: I cannot create labels in your repository.

* I think the hashtags last year were used because all list values existed in the issue template: the way to distinguish those required by a project was by adding a hashtag to those elements, and then the labeler had it matches. Not sure what the raw text looks like for an issue with the proposed template, so I cannot tell whether the labeler will get them right.

Opening a bunch of issues here for testing would clutter things IMO, so @Remi-Gau would you upload the labels to your fork (or provide me with rights to add labels) to see if the above works ??

I'm approving so as to get things going forward. Issues with the template can be fixed in separate PRs.

OK so I will merge this here and we test things on my repo once I added the labels.

* see if the `issue to pages` workflow is working with this template, and if not, how to fix it. The repository URL will be one thing to change. The action should be triggered when an issue is opened, so that will cast light on its potential issues.

I guess this can be tested on my side too, no?

jhlegarreta commented 2 years ago

I guess this can be tested on my side too, no?

Yep.

jhlegarreta commented 2 years ago

By opening an issue in Rémi's fork I've realized that if a file is dropped in one of the fields that is not expected to contain anything other than text, we might run into issues when trying to generate the project data for the workflow.

jhlegarreta commented 2 years ago

I ran the script in PR #40 on the repository here https://api.github.com/repos/Remi-Gau/global2021/

and leaving apart the status:published filtering, the issue data got parsed without breaking for the existing issue. A few notes, though:

The regexes may need to be adjusted to look for ### {field_name} to ensure that the field hit is the desired one: e.g. (?<=### Description[^\v]{2})(.*)(?=[^\v]{2}###) would catch the data in the description (tested).