search

brainhackorg / global2021

Website for Brainhack global 2021
https://brainhack.org/global2021/
MIT License
3 stars 11 forks source link

BUG: Provide explicitly the module path in workflow #97

Closed jhlegarreta closed 2 years ago

jhlegarreta commented 2 years ago

Provide explicitly the module path in the issues to pages workflow: add the path to the code to the PYTHONPATH environment variable.

Fixes:

Traceback (most recent call last):
  File "scripts/transform_issues_to_pages.py", line 16, in <module>
    from scripts.issues_to_pages import (
ModuleNotFoundError: No module named 'scripts'
Error: Process completed with exit code 1.

Reported at: https://github.com/brainhackorg/global2021/runs/4237502825?check_suite_focus=true#step:5:21

Fixes #96.

jhlegarreta commented 2 years ago

Not sure why the workflow was working yesterday then.

Not sure if the fix will work, but I'd give it a try/merge. Have fixed a similar issue in another repository I contribute to. If it does not, then it is the moment to transfer it to another repository to properly provide the package (at least through git).

jhlegarreta commented 2 years ago

Once this merged and hopefully working (e.g. can be tested by modifying an issue), I would transition to using this: https://github.com/brainhackorg/braintransform

And remove the remaining redundant files.

Same if once merged it is not working. But I prefer to first merge to see/learn whether the issue gets fixed, and since using the braintransform script could also be a source of hiccups.

Remi-Gau commented 2 years ago

the annoying thjing with CI is that sometimes you end up testing in production

oh well... here it goes...

everyone stand back!! we are merging!!!

jhlegarreta commented 2 years ago

the annoying thjing with CI is that sometimes you end up testing in production

I know how annoying this is, but I presume we cannot do better for now.

jhlegarreta commented 2 years ago

So the fix has worked. Immediately previous workflow: https://github.com/brainhackorg/global2021/runs/4247051626?check_suite_focus=true commit e065bb1958406b4386fa0fc70b5434751f210c5e

Immediately after the fix had been merged: https://github.com/brainhackorg/global2021/runs/4247118668?check_suite_focus=true commit 3e3f18861c8bfc3c3f9343c141b355e88c26825b

Remi-Gau commented 2 years ago

Sweeeet !!!

FYI: my statement was more of a general thing that sometimes with CI it feels like trial and errors rather than planned development