brainhackorg / global2022

Github repo for the brainhack 2022 website and event
https://brainhack.org/global2022/
MIT License
3 stars 6 forks source link

adding brainart 2022 images #11

Closed vborghe closed 1 year ago

vborghe commented 1 year ago

should close #4

vborghe commented 1 year ago

Sorry for not thinking about it! Should be much better now

Remi-Gau commented 1 year ago

Side note: there are some changes that need to be made if you want to say which image should go where.

See here for example: https://github.com/brainhackorg/global2022/blob/81bf053da9c2b0d9302ed35d61b9cd6f1ede0e80/content/home/team.md?plain=1#L34

But I can take care of that, if you prefer (if you trust my artistic skills... you should not).

If I do that I may do it directly by pushing to this PR otherwise the deploy would not be pretty I think.

vborghe commented 1 year ago

that baby is still a bit fat: brain_art/Brainception_HüdenNeşe.png

Sorry again, I just forgot to delete the fat one, the slim version should be already there and be ~300 KB

Remi-Gau commented 1 year ago

Sorry for not thinking about it!

And if you knew how often I have pushed large images on websites and blew up the size of some git repo because of that...

If github made us pay for large commits... I would have sold most of my organs just to pacify them.

Remi-Gau commented 1 year ago

Will also do a squash merge to avoid having those large files appear in the history.

vborghe commented 1 year ago

good with me

if you give me a 👍 I will take care of deciding which image goes where by pushing to this PR.

if so that will happen during the weekend

BTW: the images are gorgeous. 😍

Thank you! I've modified three of them, but feel free to make judgment calls here & there. Mercii!

Remi-Gau commented 1 year ago

still don't know how to push to a PR when it was opened from main... I still need to learn

will open another PR that still has your work @vborghe

sorry

Remi-Gau commented 1 year ago

@vborghe

had to open 2 more PRs to do this but eventually it worked

let me know if you catch something obvious missing: https://brainhack.org/global2022/