brainhubeu / react-carousel

A pure extendable React carousel, powered by Brainhub (craftsmen who ❤️ JS)
https://brainhub.eu/
MIT License
1.07k stars 164 forks source link

Nav Carousel and block carousel #495

Open astroVibes opened 4 years ago

astroVibes commented 4 years ago

Hi brainhubeu and thank you for your wonderful work, I was thinking of an addition in the features to make your component even more complete and competitive.

1) It would be fantastic if there was the possibility of having a navigation menu and under the components of the individual items, I attach a screen to be more clear. By default the first menu item is visible (in the case of the Lorem title screen) when you click / turn on the Ipsum item the content of Lorem is replaced with the new carousel.

2) This point I do not know if it is already possible I have seen the documentation but I did not seem to see it, I noticed that if on the desktop I set the slidesPerPage = {6} and I actually have only 6 elements there is the effect of the carousel and it scrolls horizontally, in my humble opinion even in terms of UX it would not have without and it would be better to block it.

I hope it was clear enough and I apologize for my English

Immagine

piotr-s-brainhub commented 4 years ago

Thanks, @astroVibes for proposing this.

There's a similar proposition https://github.com/brainhubeu/react-carousel/issues/326 but it's only about displaying a text box always on top of an image. I see, your text boxes should be clickable.

You can invite your colleagues to vote for this issue (with 👍) so more 👍it has, it'll be more likely to be implemented.

You can also submit a PR implementing this.

astroVibes commented 4 years ago

I see, your text boxes should be clickable. Yes is better if possible clickable

Ok thank you for all

piotr-s-brainhub commented 4 years ago

I see, your text boxes should be clickable. Yes is better if possible clickable

Ok thank you for all

You're welcome.